On Mon, 14 Nov 2022 22:58:02 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java >> line 209: >> >>> 207: configuration.getMessages().warning(holder, >>> "doclet.noInheritedDoc", signature); >>> 208: } >>> 209: return writer.getOutputInstance(); // TODO: consider invalid >>> rather than empty output >> >> very much so. >> >> Maybe consider constructing content in each of the arms of the if-else >> chain, and then (if possible) get at the method to create invalid output. >> Look for `HtmlDocletWriter.invalidTagOutput`. Maybe that method should be >> moved to `TagletWriter[Impl]`. > > ping... I would avoid such a refactoring for now. Speaking on invalid input: it is good to have, but it's a 2% improvement. I don't think we have time to make it now (RDP 1 is close). ------------- PR: https://git.openjdk.org/jdk/pull/10746
