On Fri, 28 Oct 2022 19:08:43 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 49 commits: >> >> - refactor: improve error handling >> - refactor: clarify, reuse, simplify, clean up >> - refactor: pass Utils & BaseConfiguration to taglet >> >> This simplifies lots of methods. Later this could be done for other >> taglets too. >> - refactor: better code comments >> - refactor: add more relevant excerpts from JLS >> - fix: introduce more control to search >> >> This is done for the sake of `@throws`. Two convenience methods are >> added to assist migration from Optional with minimal change to >> DocFinder call sites. >> >> This solves 8295800: When searching documentation for an exception, >> don't jump over methods that don't mention that exception. >> - refactor: clean up ThrowsTaglet >> - Merge branch 'master' into HEAD >> - fix: test failed due to filesystem handling issues >> >> Filed 8295543 to track that filesystem issue and fixed the test to make >> sure the package cannot be confused with the type parameter, whose >> name is not pertinent to the test anyway. >> - Merge branch 'master' into 8285488 >> - ... and 39 more: https://git.openjdk.org/jdk/compare/628820f4...c2db1ae6 > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java > line 782: > >> 780: } >> 781: var enclosingElementDescription = >> detailedDescriptionOf(e.getEnclosingElement()); >> 782: return enclosingElementDescription + " " + >> thisElementDescription; > > A named package is enclosed by a module, although it may be the unnamed > module for >= JDK 9. > A well-formed named module never has an unnamed package. > > Consider return empty string from the switch and dealing with that in the > `return` statement. > > That being said, who uses this info where: you're including the raw element > kind in the result, so is this mostly for debugging? It will need to be better stringified and i18n-zed. That output is not for debugging, it's for diagnosing. ------------- PR: https://git.openjdk.org/jdk/pull/10746
