> Please review a change that brings the implementation of > `DocTrees.getElement(DocTreePath)` in agreement with `javax.lang.model` > behavior by returning `null` for `DocTree` instances referring to a primitive > or array type. Additionally, this adds some missing functionality to the > implementation of the related `DocTrees.getType(DocTreePath)` method and > improves test coverage for both methods. > > Internally, the member lookup part in method > `JavacTrees.attributeDocReference` is split into a separate `resolveMember` > method that can also be used by `getType`. > > We also improve attribution of references with explicit module name by > attempting to attribute the referenced type and checking whether the module > matches the name in the reference afterwards. This allows us to support > parameterized types in references with explicit module id. > > In `test/langtools/tools/javac/doctree/ReferenceTest.java` we add some > missing test coverage such as for type parameter references, and add tests > for `DocTrees.getType(DocTreePath)` to the existing tests for > `DocTrees.getElement(DocTreePath)`. The former was previously ony covered in > javadoc tests.
Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision: Undo changes to javax.lang.model API ------------- Changes: - all: https://git.openjdk.org/jdk/pull/29547/files - new: https://git.openjdk.org/jdk/pull/29547/files/b2d792d8..03e1198a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=29547&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29547&range=01-02 Stats: 6 lines in 2 files changed: 0 ins; 4 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/29547.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/29547/head:pull/29547 PR: https://git.openjdk.org/jdk/pull/29547
