On Tue, 3 Feb 2026 15:51:25 GMT, Hannes Wallnöfer <[email protected]> wrote:
> Please review a change that brings the implementation of > `DocTrees.getElement(DocTreePath)` in agreement with `javax.lang.model` > behavior by returning `null` for `DocTree` instances referring to a primitive > or array type. Additionally, this adds some missing functionality to the > implementation of the related `DocTrees.getType(DocTreePath)` method and > improves test coverage for both methods. > > Internally, the member lookup part in method > `JavacTrees.attributeDocReference` is split into a separate `resolveMember` > method that can also be used by `getType`. > > We also improve attribution of references with explicit module name by > attempting to attribute the referenced type and checking whether the module > matches the name in the reference afterwards. This allows us to support > parameterized types in references with explicit module id. > > In `test/langtools/tools/javac/doctree/ReferenceTest.java` we add some > missing test coverage such as for type parameter references, and add tests > for `DocTrees.getType(DocTreePath)` to the existing tests for > `DocTrees.getElement(DocTreePath)`. The former was previously ony covered in > javadoc tests. This pull request has now been integrated. Changeset: 4d9d2c35 Author: Hannes Wallnöfer <[email protected]> URL: https://git.openjdk.org/jdk/commit/4d9d2c352b9daa8bdecea5303f49f2496c127115 Stats: 238 lines in 8 files changed: 131 ins; 53 del; 54 mod 8284315: DocTrees.getElement is inconsistent with Elements.getTypeElement Reviewed-by: jlahoda, vromero ------------- PR: https://git.openjdk.org/jdk/pull/29547
