Ok, but this is a name mapping problem that is a function of the persistent store. Database columns/tables will also only allow certain names. We should simply have a name mapping interface that can be specified as an attribute of the persistence manager so that the PMs can externalize how the queue name is mapped onto a valid name for their deployment environment specific store. I don't see this problem as an issue that should force naming restrictions on the queues and topics.
----- Original Message ----- From: "David Budworth" <[EMAIL PROTECTED]> To: "Scott M Stark" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Thursday, November 29, 2001 6:25 PM Subject: Re: [JBoss-dev] JMS queue names (again) > > The current problem is that the queue name specified in the mbean > descriptor (Or created via the 8082 interface), get's taken literally > and used as the directory to store the persistent messages. > > So: > <mbean > code="org.jboss.mq.server.QueueManager" > name="JBossMQ:service=Queue,name=myCompany/myQueue"> > <mbean-ref > name="JBossMQService">JBossMQ:service=Server</mbean-ref> > </mbean> > > attempts to create a directory: > db/jbossmq/file/QUEUE.myCompany/myQueue > > Which would not be valid except on unix FSs > > This deploy fine, but the real problem comes on restart of jboss. > > The file PM attempts to pre-restore all queues before they are deployed, > and to do this, it does a "db/jbossmq/file/".listFiles() and assume that those > were the actual queue names (minus the "QUEUE."). > > Which would fail to restore the message log since > ...file/QUEUE.myCompany is in fact just the parent dir for the message > store for myCompany/myQueue > > I added code that recognized this. But of course I wasn't thinking of > the non-unix folks, where using the queuename literally as the dir name > might not be valid for their fs. > > Personally, I don't like having the queuename map directly to the FS > names, I'd much rather have generated dir names, and a map file. > > But that makes human administration of the FS a little more complex, and I > didn't get a response from anyone if that was ok to do. And not > knowning if the queuename->dirname mapping was for a reason, I didn't > want to change it. > > > I don't know what are valid FS chars for each OS, which is why I > suggested making is alpha-numeric restricted. (example, can you have a > comma in a AS400 filename?) > > -David > > On Thu, 29 Nov 2001, Scott M Stark wrote: > > > > > That would seem to be a little too restrictive a naming requirement. > > Using isJavaIdentifierPart may be more acceptable. What is the > > current naming problem? > > > > ----- Original Message ----- > > From: "David Budworth" <[EMAIL PROTECTED]> > > To: <[EMAIL PROTECTED]> > > Sent: Thursday, November 29, 2001 5:22 PM > > Subject: [JBoss-dev] JMS queue names (again) > > > > > > > Ok, now that we have the ability to set the JNDI name on a queue/topic, > > > I would like to fix the bug (that I put in) in regards to deep queue > > > names. > > > > > > For simplicities sake, I'll just revert the file PM back to the way it > > > was. > > > > > > But, since there was (and will be when I revert) a bug there that if > > > you create a queue/topic with depth (ie: mycompany/queues/q1) > > > > > > The File PM will fail at next startup. > > > > > > So, I'd like to add some name validation. > > > > > > Is anyone uncomfortable if I enforce the queue names to be alpha-numeric > > > only? (via, Character.isLetterOrDigit()) > > > JBoss (as it ships), doesn't define any topics/queues that would violate > > > that rule right now. > > > > > > Opinions? > > > > > > -David > > > > > > > > > > > _______________________________________________ > > Jboss-development mailing list > > [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/jboss-development > _______________________________________________ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
