I think Adrian is correct in that a HARDeployer and a SARDeployer are conceptually very different "things". There is certainly a lot of overlap in functionality (the worst part being the xml parsing).
After further thought on this, it seems a much better approach here is the simply better encapsulate this redundant logic into delegates. Especially if you think about the parsing of the service descriptors. Maybe even a JBoss XMBean "thingy". Then others can easily re-use that logic in custom deployers. I remember now what brought me to this situation now. Currently what the HARDeployer does is to essentially say that its 'hibernate-service.xml' file is a sub-deployment (i.e., SubDeployerSupport.isDeployable). The sole reason it does this is so that the SARDeployer can then pick it up and parse the xml descriptor, register mbeans... yuck! I was trying to clean that up so that the "nested deployment" concept was not needed. So I guess, in a way, a HAR deployment *is* is SAR :) View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=3872775#3872775 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=3872775 ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ JBoss-Development mailing list JBoss-Development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jboss-development
