----- Original Message ----- > Hi Andrew, thanks for your hard work. > > We will probably use these changes, and do a fair amount of testing. But > that will take a while, probably too long for you to wait on us for review. > > I recently did a "mega-commit", and published a hg mq directory in addition > to webrev. > > These kinds of changes are "unreviewable", but let's try... > Looking at > http://cr.openjdk.java.net/~andrew/openjdk7/20151020/jdk/ > I see ancient changes like this, which is probably unintentional, so maybe > your webrev-generation script needs adjustment: > > rev 640 : 6730743 > <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6730743>: (tz) > Support tzdata2008e > Reviewed-by: okutsu > >
FWIW, I checked the patch files [0] before I posted and they look fine. It's just something in the web page generation that's broken. [0] e.g. http://cr.openjdk.java.net/~andrew/openjdk7/20151020/jdk/jdk.patch -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07