Fujiwara-san,
Generally looks okay, some comments, issues, questions below:
On Wed, 2007-01-10 at 21:18 +0900, Takao Fujiwara - Tokyo S/W Center
wrote:
> +%if %build_l10n
> +bzcat %SOURCE8 | tar xf -
> +cd po-sun; make; cd ..
> +%endif
I noticed that you add make commands to the %prep section.
This is a bit unusual. What does it do?
> +++ gnome-panel-2.16.1-hacked/gnome-panel/menu.c 2006-11-16
> 01:39:21.692923000 +1300
> -@@ -1799,13 +1799,93 @@
> +@@ -1799,13 +1799,94 @@
> setup_menuitem (item, icon_size, NULL, title,
> create_invisible_mnemonic);
> }
>
> @@ -36,6 +36,7 @@
> +
> + item = gtk_image_menu_item_new ();
> +
> ++ /* SUN_BRANDING *
Oops! That should be a "*/" at the end, right?
> - children = gtk_container_get_children (GTK_CONTAINER
> (main_menu));
> -+ item = add_xdg_menu (_("All Applications"),
> "applications.menu", "gnome-applications");
> ++ /* SUN_BRANDING */
> ++ item = add_xdg_menu (_("Applications"), "applications.menu",
> "gnome-applications");
Why did you change the English string from "All Applications" to
"Applications"?
Thanks,
Laca
