On Thu, 2007-01-11 at 22:39 +0900, Takao Fujiwara - Tokyo S/W Center wrote:
> > I noticed that you add make commands to the %prep section. > > This is a bit unusual. What does it do? > > The make uses spec-files/po-sun/Makefile.template > Please find the following part. > + echo "Merging $$po_sun ..."; \ > + msgcat --use-first $$po_sun $$po -o $$po; \ > I thought msgcat as the patch of .po likes the patch of source codes. > Why I use make is the change is one line in .spec file. Ah, okay, so this is part of setting up the source tree, so it really belongs in %prep. Thanks. > Do you mean "make on %prep" may be unusual? > If so, how about the following options? > > - Change "make" to "make prep-after". > - Change the make command to a script on prep. e.g. "bash -x foo.sh" No, that fine, please leave it as in the original patch. > > Why did you change the English string from "All Applications" to > > "Applications"? > > Sorry, I thought "All Applications" is typo because the internal > ui-spec/launch.htm shows both "Applications" and "All Applications" and JDS > 3.1 is "Applications". > e.g. "Main->Applications->Accessories" > I cannot grep "All Application" translations from JDS 3.1 messages files so > it will be a new string. > I'll change "Applications" to "All Applications". I don't know what it should be, just noticed that it was different. Calum? Thanks, Laca
