Hello Kohsuke, looks really nice! One small issue: - when using the menu from the dashboard hovering over one job name, there is the option to return to the dashboard, which seems superfluous to me :-).
Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ https://bitbucket.org/mfriedenhagen/ On Wed, Feb 29, 2012 at 01:22, Kohsuke Kawaguchi <[email protected]> wrote: > > I've pushed this in > https://github.com/jenkinsci/jenkins/tree/breadcrumb > > Most of the list view links now support navigation menus (it's just a matter > of adding class='model-link' to the <a> tag), so you can get the sense of > how this behaves. > > You need to hover the mouse on <a> tags and wait for a bit before the menu > shows up. I added this delay intentionally --- without it, it's way too easy > for unintended menus to open as you move the mouse from one part of the page > to another. > > I think I like it, but as always, feedback welcome. > > I'm expanding the ui-samples plugin to describe how it works and how to take > advantages of this from plugins. > > On 02/28/2012 04:16 AM, Kohsuke Kawaguchi wrote: >> >> The implementation is done in such a way that there's no extra data >> loaded until you actually activate the menu (by hovering the mouse >> over), so I think we are OK with this regard. >> >> 2012/2/24 Mirko Friedenhagen<[email protected]>: >>> >>> My only concern would be to test this with bigger installations as well. >>> When having 1000 jobs in one instance innocent looking 200 bytes of >>> information per job may make a big difference :-D. >>> >>> Regards Mirko >>> -- >>> Sent from my phone >>> http://illegalstateexception.blogspot.com >>> http://github.com/mfriedenhagen/ >>> https://bitbucket.org/mfriedenhagen/ >>> >>> On Feb 24, 2012 7:40 PM, "domi"<[email protected]> wrote: >>>> >>>> >>>> I also think that having this option on every model object would be a >>>> really good idea. >>>> e.g. this could be useful in the executor list too >>>> /Domi >>>> >>>> >>>> On 24.02.2012, at 00:26, Kohsuke Kawaguchi wrote: >>>> >>>> > Hmm, that's interesting. It is relatively easy to build this on top >>>> of >>>> > what we have. >>>> > >>>> > Definitely worth experimenting. Any thoughts on this from others? >>>> > >>>> > 2012/2/24 Dean Yu<[email protected]>: >>>> >> It would be great if the menu could be activated from any link to a >>>> >> model >>>> >> object, not just from the breadcrumb bar. For example, there have >>>> been >>>> >> many >>>> >> times I wished I could quickly jump to the configuration or console >>>> of >>>> >> a job >>>> >> from the upstream/downstream jobs section of a page. We could get >>>> rid >>>> >> of a >>>> >> lot of custom dashboard view columns if the menu could be activated >>>> >> from the >>>> >> links in the views. >>>> >> >>>> >> This would mean refactoring all model object links in Jelly files >>>> to >>>> >> use a >>>> >> modellink.jelly template, but it would be a consistent experience. >>>> >> >>>> >> -- Dean >>>> >> >>>> >> >>>> >> On 2/20/12 7:15 PM , "Kohsuke Kawaguchi"<[email protected]> >>>> >> wrote: >>>> >> >>>> >>> As per the discussion in [1], I implemented the enhanced >>>> breadcrumb. >>>> >>> The code is currently in a branch [2]. The screenshot is attached. >>>> >>> >>>> >>> Breadcrumb is now sticky --- when you scroll down, it sticks to >>>> the >>>> >>> top of the page and never goes out of the viewport. Hovering the >>>> mouse >>>> >>> over it will show the menu, and when you move your mouse out of >>>> the >>>> >>> menu, it'll disappear automatically. The breadcrumb itself is >>>> still >>>> >>> clickable as it has been. >>>> >>> >>>> >>> As you see in the screenshot, the breadcrumb now occupies more >>>> space >>>> >>> (or easiler access to the context menu), and it's bordered. >>>> >>> >>>> >>> I'm not a UX guy, and I'm not too crazy about borders here (it >>>> appears >>>> >>> somewhat out of style with the rest of Jenkins UI, although >>>> foldable >>>> >>> sidepanel might change that.) With that said, I ended up adding it >>>> to >>>> >>> create a boundary for sticky breadcrumb. >>>> >>> >>>> >>> Internally, it ses sidepanel.groovy/jelly to generate the menu >>>> >>> contents by default, which lets us instantly activate this feature >>>> for >>>> >>> all those objects that people have been writing. But model classes >>>> can >>>> >>> override this behavior and completely take over the menu >>>> generation if >>>> >>> so choose. >>>> >>> >>>> >>> Future enhancements include submenus. >>>> >>> >>>> >>> Does this sound like what we want? Feedbacks from graphics/UX guys >>>> >>> (and I'm looking at Manfred!) would be especially appreciated. >>>> >>> >>>> >>> [1] >>>> >>> >>>> >>> >>>> https://wiki.jenkins-ci.org/display/JENKINS/FOSDEM+UI+Enhancement+discussion+n >>>> >>> otes >>>> >>> [2] https://github.com/jenkinsci/jenkins/tree/breadcrumb >>>> >> >>>> > >>>> > >>>> > >>>> > -- >>>> > Kohsuke Kawaguchi >>>> >>> >> >> >> > > > -- > Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/ > Try Nectar, our professional version of Jenkins
