While I did tweak the top styling a bit, this PR is primarily about
changing the layout to use divs vs tables.
So I totally agree... sorting out font types and sizes, adding more
responsive features (collapsible menu etc etc) would be things we should
try and do, but I wasn't planning on doing it in this PR.
On 19/06/2014 07:49, Mads Nielsen wrote:
Looks great, would it be possibly to vertically center align labels to
it's attached item?, in the second one, the label for the text box is
slightly over the text input field?
On Thu, Jun 19, 2014 at 2:24 AM, Michael Neale
<[email protected] <mailto:[email protected]>> wrote:
On Wed, Jun 18, 2014 at 10:25 PM, Tom Fennelly
<[email protected] <mailto:[email protected]>> wrote:
Posting back here again to solicit feedback.
Looks great - I tried on chrome, safari (both mac) and iphone -
the responsive-isms are much appreciated.
2 things that stood out:
Font is still tiny - I find it hard to read (had to bump it up a
few sizes) - Helvetica (as mentioned in another PR) works nicely
here as you bump it up a bit - doesn't stand out as much compared
to every other web app :) Sure with a smaller font you can see a
but more - but you end up skipping over things as it is too small
to read.
When you narrow the window (eg mobile) the menu links really stand
out as out of place (I think Gus mentioned that in another
thread). A "classic" responsive thing to do here would be to
collapse them into some pop-over menu (often the infamous pancake
icon is used here) - this may be overkill, but I thought it was
interesting how well responsive worked but for those stubborn
links and their icons.
Have attached the before/after with the larger/helvetica font change.
--
You received this message because you are subscribed to the Google
Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected]
<mailto:[email protected]>.
For more options, visit https://groups.google.com/d/optout.
--
*
*
*Mads Nielsen
Consultant
Praqma A/S
*
*Tel: +45 50 98 18 09
Mail: [email protected] <mailto:[email protected]>
web: www.praqma.net <http://www.praqma.net/>*
--
You received this message because you are subscribed to a topic in the
Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit
https://groups.google.com/d/topic/jenkinsci-dev/zDaX4yiWLLw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
[email protected]
<mailto:[email protected]>.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
