Hi, Stephen: I am not sure why you asked whether build-step get re-positioned. The plugin I am proposing is simply a credential provider when authentication against Google Container Registry is needed. It does not perform any docker actions, so it needs to work with a plugin like docker-build-step.
Thanks. Wei On Sunday, June 7, 2015 at 12:12:24 PM UTC-7, Stephen Connolly wrote: > > @James/Oleg did the build-step get re-positioned as something else during > the "great experiment"? > > On Sunday, June 7, 2015, 'Wei Zheng' via Jenkins Developers < > [email protected] <javascript:>> wrote: > >> Hi, >> >> Don't know why but I am not able to post/reply to my original thread: >> >> "Request to release/publish Jenkins auth plugin for Google Container >> Registry >> <https://groups.google.com/forum/#!topic/jenkinsci-dev/vEHyY4BuG9Q>". >> >> My post/reply never showed up after I posted them. I have tried almost a >> dozen times starting from last Friday. So I am starting a new thread. Sorry >> for the inconvenience. >> I have made changes regarding its artifactId and a few other places >> related to its name. >> >> Here is my answer to Stephen and Jesse's questions after some >> investigation: >> >> >> 1. This proposed plugin is compatible with docker-commons-plugin, >> i.e. when docker-commons-plugin looks for credentials by asking >> credentials >> providers to provide one, this proposed plugin will be evoked and >> provides >> credentials accordingly. >> 2. docker-build-step-plugin need to be modified to integrate with >> docker-commons-plugin. This plugin needs docker-build-step-plugin to >> work. >> docker-build-step-plugin (after modification) will invoke >> docker-commons-plugin, which will in turn trigger this proposed plugin. >> 3. This proposed plugin (with its current implementation) works with >> docker-build-step-plugin with its current implementation (i.e. when it is >> not integrated with docker-commons-plugin), and without any modification, >> it will work with docker-build-step-plugin after its integration with >> docker-commons-plugin. I have integrated docker-build-step-plugin with >> docker-commons-plugin locally and verified this. >> 4. I will submit a pull request to docker-build-step-plugin for >> integration with docker-commons-plugin. I have contributed to its auth >> related part before, so I think my pull request should have no problem >> being approved by them. >> >> Note: >> I also renamed my repo's name due to the plugin's artificateId change, >> the new link to my repo is: >> https://github.com/wzheng2310/gcr-auth-plugin >> >> Please reply/comment, or approve. >> >> Thank you very much. >> Wei >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnSbNsKM5y0J%2BxF6vtUXy1oEQ2Dh%3DN%3D3Q6d4vViDVXpO%3Db3Tg%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnSbNsKM5y0J%2BxF6vtUXy1oEQ2Dh%3DN%3D3Q6d4vViDVXpO%3Db3Tg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > > -- > Sent from my phone > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8ad7e73b-e805-4e3c-b7c7-b118391da8e4%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
