On Thu, Jun 11, 2015 at 1:19 AM, Wei Zheng <[email protected]> wrote: > I have modified it now to use DockerRegistryEndpoint and verify that it > works, and > the plugin I am asking for hosting (Google Container Registry Auth plugin) > works with this modification as well, no change is needed in Google > Container Registry Auth plugin.
Sounds good to me, though I do not understand all the technicalities here. Anyway bugs or RFEs can always be handled later; I did not mean to hijack your original thread asking for hosting, merely to alert you to possibilities you might have missed. > So please approve my plugin if you think everything is fine Was about to fork to jenkinsci but one thing caught my eye: https://github.com/wzheng2310/gcr-auth-plugin/blob/master/CONTRIBUTING.md I am not sure if it is legitimate for a plugin hosted on @jenkinsci to require a non-Jenkins CLA. However artifactory-plugin already does (JFrog CLA), and https://wiki.jenkins-ci.org/display/JENKINS/Copyright+on+source+code does not seem to forbid this. So I created https://github.com/jenkinsci/google-container-registry-auth-plugin and https://issues.jenkins-ci.org/issues/?jql=project%20%3D%20JENKINS%20AND%20component%20%3D%20google-container-registry-auth-plugin Do not forget to create https://wiki.jenkins-ci.org/display/JENKINS/Google+Container+Registry+Auth+Plugin under https://wiki.jenkins-ci.org/display/JENKINS/Plugins with appropriate tags, and the {excerpt} etc. Welcome! -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1Nn5kwzvmt6r8GDw_oxXXc3BMWf6wbXSt9qXwibhubiQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
