On 11/06/15 15:31, Jesse Glick wrote:
On Thu, Jun 11, 2015 at 1:19 AM, Wei Zheng <[email protected]> wrote:
I have modified it now to use DockerRegistryEndpoint and verify that it works,
and
the plugin I am asking for hosting (Google Container Registry Auth plugin)
works with this modification as well, no change is needed in Google
Container Registry Auth plugin.
Sounds good to me, though I do not understand all the technicalities
here. Anyway bugs or RFEs can always be handled later; I did not mean
to hijack your original thread asking for hosting, merely to alert you
to possibilities you might have missed.
So please approve my plugin if you think everything is fine
Was about to fork to jenkinsci but one thing caught my eye:
https://github.com/wzheng2310/gcr-auth-plugin/blob/master/CONTRIBUTING.md
I am not sure if it is legitimate for a plugin hosted on @jenkinsci to
require a non-Jenkins CLA. However artifactory-plugin already does
(JFrog CLA)
Wei, you can probably remove the CLA requirement; your colleagues who
have released other Jenkins plugins have managed to do so without
requiring a CLA, e.g.:
https://github.com/jenkinsci/google-oauth-plugin
https://github.com/jenkinsci/google-storage-plugin
Regards,
Chris
--
You received this message because you are subscribed to the Google Groups "Jenkins
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/557AF8F6.9000005%40orr.me.uk.
For more options, visit https://groups.google.com/d/optout.
