Daniel Beck: We already have something similar in the "context menu" for the 'configuration' bread crumb. Can't this be reused in some way?
For the approach, I am pretty sure that is script scraping the page and appending DOM after the page renders, which we can do. But in terms of using some portion of shared code, definately not. In general, page scraping and appending DOM has the illusion of being a safeish change. The problem is that it becomes a maintenance nightmare because the DOM upon which the scraper is dependant has no indication of the nature of that dependency. The screen rendering really shouldn't be treated as an API, which is what ends up happening and leads to the sorts of refactoring issues we are confronted with now. On Wed, Jul 22, 2015 at 10:44 PM, Daniel Beck <[email protected]> wrote: > > On 23.07.2015, at 00:52, Gus Reiber <[email protected]> wrote: > > > So a ToC sort of display like Bootstrap's typically relies on a separate > rendering of the ToC from the actual content. > > At the moment, this is nothing like the way the config page is currently > rendered. There are a number of ways to fix that. We can go directly to the > jelly files and loop over the form contents twice. We can parse the page > with JS after it is rendered and attach a pegged ToC. And, I am sure there > are other solutions I am not thinking of. In all cases, though, that means > a fairly substantial change to the page DOM, ie, the injection of this ToC > block and possibly anchor points to tie the two together. > > We already have something similar in the "context menu" for the > 'configuration' bread crumb. Can't this be reused in some way? > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/Tiz-LSqCJmg/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/805A1DB3-DBD4-4F2E-958D-F6C901AFEE95%40beckweb.net > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAOcHHXzuMWrcmiyPCnbHmQFFe4z70Oac%2BkRN%2Bwguqt02pAQW1w%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
