On 02.09.2015, at 23:53, Victor Martinez <[email protected]> wrote:
> - The Extra Columns plugin is job based I'm afraid, does it make sense to > merge those functionalities? No. You cannot actually hide node columns AFAIK, so every installed + enabled plugin always contributes its columns to the list. Until this changes, having a plugin collecting node columns would be bad. Like only having the AllView and all columns being visible by default. > - Does it make sense to use % of remaining free disk space or % disk usage? Do you have options for slave columns like list view columns do, or do you need to decide on one or the other? If the latter, I'd go for % used like `df` does. > - Regarding the name of that plugin, what do you think about > "PercentageFreeDiskSpaceColumn" and "PercentageDiskUsageColumn"? Is it too > long? FWIW in general the pattern is foo-bar-baz rather than FooBarBaz. Otherwise this seems to be fine. It's a very narrow scoped plugin so the name should be descriptive. > - Finally, Do you think it should handle some thresholds based on % in order > to monitor each slave as DiskSpace does? Is it a valuable use case? Yes, absolutely. If you have very different slaves, a fixed threshold in MB or GB may be useless, but something like 90% fill level across all slaves before taking them offline may work. Assuming nobody objects (I explained why a collection plugin, or really any integration with something related, would be bad here) I'll fork this tomorrow. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/890F7A95-C62C-4716-8B24-63DDA68AED4D%40beckweb.net. For more options, visit https://groups.google.com/d/optout.
