Awesome Thanks Daniel, Regarding your question, I just wanted a tiny plugin with simple functionality rather than a complex one which might be harder to maintain. Thanks for the advice of the plugin name, I've just renamed it as "percentage-du-column"
*Repo*: https://github.com/v1v/percentage-du-column-plugin Let me know if you need further clarification Thanks again On Tuesday, 15 September 2015 00:25:20 UTC+2, Daniel Beck wrote: > > > On 02.09.2015, at 23:53, Victor Martinez <[email protected] > <javascript:>> wrote: > > > - The Extra Columns plugin is job based I'm afraid, does it make sense > to merge those functionalities? > > No. You cannot actually hide node columns AFAIK, so every installed + > enabled plugin always contributes its columns to the list. Until this > changes, having a plugin collecting node columns would be bad. Like only > having the AllView and all columns being visible by default. > > > - Does it make sense to use % of remaining free disk space or % disk > usage? > > Do you have options for slave columns like list view columns do, or do you > need to decide on one or the other? If the latter, I'd go for % used like > `df` does. > > > - Regarding the name of that plugin, what do you think about > "PercentageFreeDiskSpaceColumn" and "PercentageDiskUsageColumn"? Is it too > long? > > FWIW in general the pattern is foo-bar-baz rather than FooBarBaz. > > Otherwise this seems to be fine. It's a very narrow scoped plugin so the > name should be descriptive. > > > - Finally, Do you think it should handle some thresholds based on % in > order to monitor each slave as DiskSpace does? Is it a valuable use case? > > Yes, absolutely. If you have very different slaves, a fixed threshold in > MB or GB may be useless, but something like 90% fill level across all > slaves before taking them offline may work. > > Assuming nobody objects (I explained why a collection plugin, or really > any integration with something related, would be bad here) I'll fork this > tomorrow. > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/4d6546cc-9eed-4d71-8468-7e14066e2f76%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
