@Ulrich, see my initial post, i proposed "conservative" start rules and proposed automated github PRs verification that doesn't block PR merge and only indicate with comments on possible bad places.
One more addition https://github.com/jenkinsci/jenkins/pull/1907#issuecomment-154416520 On Friday, November 6, 2015 at 4:29:21 PM UTC+3, Ullrich Hafner wrote: > > I would also recommend to define and publish an official coding style. > This is practice for all professional software projects. I don’t see why > this should not be done in an open source project. If we can’t agree to an > overall style we should at least start with a small subset of conventions > that can be extended step by step. (But this is just my opinion as a > plug-in developer, it is a decision the core team should actually make.) > > It was really hard to argue with students in my testing class why the > acceptance test suite has no official coding standard while the students > learn in all lectures that a project team should follow a coding standard. > So we ended up in forking the project, creating and committing a coding > standard for the class, and finally removed the standard after the end of > the semester. > > I’m using a committed coding standard for my plug-ins and it works quite > well. Normally, PRs follow this coding standard (at least after mentioning > it). > > I also think that we should first define a coding standard. *After* that > we can discuss if it is automatically applied or just provided as formatter > preferences. I the latter case we should enforce these rules using static > code analysis. > > (Note: a coding style consists of formatter preferences as well as a set > of coding practices or guidelines, e.g., fields must be private, etc.) > > Am 02.11.2015 um 14:54 schrieb Kanstantsin Shautsou <[email protected] > <javascript:>>: > > <sorry-for-offtopic> > http://techbeacon.com/zombie-code-when-maintainability-goes-out-window > </sorry-for-offtopic> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/9063c95b-b8b2-42b9-87e5-a63fd0c8ce06%40googlegroups.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/9063c95b-b8b2-42b9-87e5-a63fd0c8ce06%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1595bf88-3802-4f7d-a691-e2d2b149947a%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
