Sorry, but imho this PR kills code. Will be glad to hear why jenkins should add walkmod that i never saw in any projects instead of mass used checkstyle (this thread is about styling). Modified parts (Serializable, readResolve()) in PR reportable by FindBugs that is static analysing tool.
> On Dec 21, 2015, at 11:56, Raquel Pau Fernández <[email protected]> wrote: > > Hi to everyone, > > I have created an open source tool called Walkmod for this purpose (link - > http://www.walkmod.com). In fact, I executed Walkmod into Jenkins (core > module) to remove dead code. This PR contains the results > https://github.com/jenkinsci/jenkins/pull/1957. > > Walkmod allows you define your code conventions and fixes the code. It is > possible because code conventions are implemented as code transformations. > After all code transformations are executed, Walkmod writes the file using > an specific Eclipse formatter or just modifying the original source file with > the minimum semantic or syntactic changes (e.g add @Override). > > Moreover, there is a service called walkmodhub whose purpose is to execute > walkmod incrementally for each push. Then, walkmod sends a PR with the > necessary changes and nobody needs to change their habits. > > Let me know your opinions. > > Raquel > > > El martes, 10 de noviembre de 2015, 22:38:33 (UTC+1), Stephen Connolly > escribió: > On 10 November 2015 at 21:34, Jesse Glick <[email protected] > <javascript:>> wrote: > On Tue, Nov 10, 2015 at 3:22 PM, Stephen Connolly > <[email protected] <javascript:>> wrote: > > None of those match "Jesse"-style so hopefully we can kill that abomination > > off ;-) > > CheckStyle is a syntactic, not semantic, processor so it cannot > distinguish between adjectival annotations, determiners, and type > qualifiers. > > > Which is why we should put annotations on the line(s) before the method/field > declaration > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2QF7BgnazAaf6w2p_N2Fcu5bGoGgvSFbQUo9DSdsvpxQ%40mail.gmail.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2QF7BgnazAaf6w2p_N2Fcu5bGoGgvSFbQUo9DSdsvpxQ%40mail.gmail.com>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. > > > -- > You received this message because you are subscribed to a topic in the Google > Groups "Jenkins Developers" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/jenkinsci-dev/8fjvXGYbFJ4/unsubscribe > <https://groups.google.com/d/topic/jenkinsci-dev/8fjvXGYbFJ4/unsubscribe>. > To unsubscribe from this group and all its topics, send an email to > [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/33067c26-6b0a-482c-9523-a723e0518adb%40googlegroups.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/33067c26-6b0a-482c-9523-a723e0518adb%40googlegroups.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/EB3D6FEF-2E16-4ED5-BE22-52D3F26BB9DA%40gmail.com. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: Message signed with OpenPGP using GPGMail
