On 8 March 2016 at 20:39, Daniel Beck <[email protected]> wrote: > > On 08.03.2016, at 21:29, Stephen Connolly <[email protected]> > wrote: > > > 2. Request review > > 3. Wait > > 4. If PR is no-longer mergable, or needs fix-up due to other PRs merged, > Then fix up PR and Goto 2 > > FWIW I would not consider most fix ups cause to go back to #2 if there > have been positive reviews of the original version. >
So you are saying that somebody making fix-ups won't make mistakes and the changes do not need re-review? It's hard enough in the current process to know at what point you have the OK to merge... > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/1F7F3EB2-706E-4E38-837A-903D126442D0%40beckweb.net > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMzSmPDviB_r_LZ9nhkfysWvTLafC%3DAW5-mecpUkFgdBmw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
