On Wednesday, March 9, 2016 at 12:45:40 AM UTC+3, Stephen Connolly wrote: > > On 8 March 2016 at 20:39, Daniel Beck <[email protected] <javascript:>> > wrote: > >> >> On 08.03.2016, at 21:29, Stephen Connolly <[email protected] >> <javascript:>> wrote: >> >> > 2. Request review >> > 3. Wait >> > 4. If PR is no-longer mergable, or needs fix-up due to other PRs >> merged, Then fix up PR and Goto 2 >> >> FWIW I would not consider most fix ups cause to go back to #2 if there >> have been positive reviews of the original version. >> > > So you are saying that somebody making fix-ups won't make mistakes and the > changes do not need re-review? > > It's hard enough in the current process to know at what point you have the > OK to merge... > I think it depends on contributors quality, somebody may request final review, somebody may merge. But that definitely better than invisible commits to master.
@Stephenc, when you are watching `jenskinci/jenkins` repository, are you getting notifications for all commits? I think no. How do you expect people reviewing/knowing about code changes without PRs? (Even if your change was right.) Do you think that your change is super important and everybody should be ignored? Or that’s personal kohsuke’s project that allows doing anything he want without caring on cooperation with other contributors that made a lot of https://github.com/jenkinsci/jenkins/graphs/contributors and testing? This wasn't an automation or release process commit. It wasn't so difficult to make PR and keep discussions in PR thread that will have comments in it and not in commit. PR would allow ensure that build at all buildable. I think the first small step should be to use PRs as gate of changes and degree of review could be adopted later. > > >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/1F7F3EB2-706E-4E38-837A-903D126442D0%40beckweb.net >> . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1eea0a94-bd31-43bf-8090-67586c3a9e45%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
