Personally the way I see it possibly the issue isn't really with having a PR or not - it seems to me that the issue was more with not having a discussion first somewhere prior to committing about the approach / issue. (Or maybe there was - in which case ignore my view :) )
Richard On Thu, 10 Mar 2016 6:07 am Suckow, Thomas J <[email protected]> wrote: > Not being an iCLA signer I have experienced the loop of death and that’s > fine. I do not however wish it on iCLA signers. > > Would an acceptable compromise be that people with push access are allowed > to optionally "skip" the human review portion of the PR? It would still > require that Jenkins is able to build the PR before they are allowed to > merge. > > 1. Submit PR > 2. Wait for Jenkins to verify > 3. If PR is no-longer mergable, or needs fix-up due to other PRs merged, > Then fix up PR and Goto 2 > 4. Merge PR > > Since it was a PR, people could still review it after the fact. I would > also encourage them leaving it for review. But I imagine the biggest > annoyance would be for bug fixes which should be lower risk and there is a > high desire to get merged quickly. > > - > Thomas > > From: <[email protected]> on behalf of Stephen Connolly < > [email protected]> > Reply-To: "[email protected]" <[email protected] > > > Date: Tuesday, March 8, 2016 at 12:29 PM > To: "[email protected]" <[email protected]> > Subject: Re: Proposal: forbid direct commits to master for core > > I think I am now against this proposal. At least without an > agreed mechanism to make large cross-cutting changes without ending up in > the: > > 1. Submit PR > 2. Request review > 3. Wait > 4. If PR is no-longer mergable, or needs fix-up due to other PRs merged, > Then fix up PR and Goto 2 > 5. Merge PR > > steps 2-4 loop of death. > > Especially with a change that is open to debate, every time it is > resubmitted for review, you will run the gauntlet of trying to get everyone > to agree *again*. > > There are some changes which are not well suited to either a PR or a > feature branch. > > Find a process that can enable those changes and I am all for that > process... But blanket banning direct commits without enabling movement on > fixes to core issues such as the idiotic forcing all plugins to change from > getInstance to getActiveInstance because <5% of the callers in core have a > need to work outside of the lifecycle of the singleton and some plugins > want to break things by dragging the Jenkins class over to the remote class > loaders... That will just drag the code base into the tarpit of dispair > > On Tuesday 8 March 2016, Kanstantsin Shautsou <[email protected]> > wrote: > >> Keeping just for logging of this topic to save future time during >> searching examples >> >> https://github.com/jenkinsci/jenkins/commit/bb7c8fcedbcc9b51c5b1bb5b32810af5ac6b1ffb >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/851cc3bd-5d6b-46db-acc9-d1f04874ae8e%40googlegroups.com >> <https://groups.google.com/d/msgid/jenkinsci-dev/851cc3bd-5d6b-46db-acc9-d1f04874ae8e%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > > -- > Sent from my phone > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMwsYad6nVBK8pp5de6Z%2BezyXpPbRMrDXZzZZY3Zm7Jttw%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMwsYad6nVBK8pp5de6Z%2BezyXpPbRMrDXZzZZY3Zm7Jttw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/D305962B.282AE%25thomas.suckow%40pnnl.gov > <https://groups.google.com/d/msgid/jenkinsci-dev/D305962B.282AE%25thomas.suckow%40pnnl.gov?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMui9467nQ6rZps7wFYiUO8tM_J%3Ds4oQ3VPQzQary%2BH3Y99p6A%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
