Adding/removing a node currently requires that the queue lock be held as otherwise the scheduling will blow up in your face.
Best plan is typically to off-load to a clean thread if your call path is in any way complex On Monday 17 October 2016, Surya Gaddipati <[email protected]> wrote: > ooops forgot to mention. Ditto for `removeNode` method. > > On Monday, October 17, 2016 at 9:53:23 AM UTC-5, Surya Gaddipati wrote: >> >> Hi all, >> >> I am working on plugin >> <https://github.com/suryagaddipati/jenkins-docker-swarm-plugin> that >> creates a single use computer/node whose lifecycle is tied to a single >> build . I am currently adding the node like this >> >> Jenkins.getInstance().addNode(node); >> >> >> However that method requires multiple Queue locks while doing so. >> >> >> I believe in my particular case there is no need for queue locking since >> only a single build can ever be scheduled on the computer via >> LabelAssignmentAction. >> >> I wanted to check , >> >> 1. if that assumption is correct >> >> 2. If the team is open to accepting a patch to jenkins.instance for a >> new method which adds a node without the Queue lock. >> >> >> Thank you. >> >> >> --Surya >> > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <javascript:_e(%7B%7D,'cvml','jenkinsci-dev%[email protected]');> > . > To view this discussion on the web visit https://groups.google.com/d/ > msgid/jenkinsci-dev/377a23fc-6043-4e62-b8fa-b9cf58eb6684% > 40googlegroups.com > <https://groups.google.com/d/msgid/jenkinsci-dev/377a23fc-6043-4e62-b8fa-b9cf58eb6684%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- Sent from my phone -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMzL894Rg3szt%2BmpDCHP-oXgON9XZr4M3abJKvfhSdWH5g%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
