>thus encapsulated the API calls you are struggling with.

Oh yea I remember seeing that somewhere too. I remember seeing a commit on 
jenkins core for this too. 


But thats not the issue I am talking about here. 

Let me summarize this discussion,  

Jenkins.getInstance().addNode(node);


This code locks the queue. Locking the queue for adding single-use node is 
not necessary.  I am still not clear what Stephen is inferring with 
''issues start cropping up' , neither concerrentmodificationexception nor 
scheduling on zombie node are applicable here .

I am asking if you'd accept a patch to core that adds nodes to 
jenkins without unnecessary queue locking. 


-- Surya





On Tuesday, October 18, 2016 at 10:20:06 AM UTC-5, Jesse Glick wrote:
>
> On Mon, Oct 17, 2016 at 5:47 PM, Surya Gaddipati 
> <[email protected] <javascript:>> wrote: 
> > yes like that, there are a couple of differences 
>
> IIRC there was a more abstract plugin which purported to provide an 
> API to allocate a node for the duration of one build only, and which 
> thus encapsulated the API calls you are struggling with. I do not 
> recall offhand where it is. @Nicolas? 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/76a7fd8f-25d8-4a60-8a86-2936ce59c4db%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to