Hi Oleg, I think the DTKit plugin library was done externally to make extension easier.
For example a plugin could extends org.jenkinsci.lib.dtkit.type.TestType other few interfaces to be added as tool type on xUnit plugin regardless of the version of xunit and its dependencies. - https://github.com/jbehave/jbehave-core/tree/master/jbehave-jenkins-plugin - https://github.com/jenkinsci/gallio-plugin/tree/master/src/main/java/hudson/plugins/gallio So you suggest to move code from DTKit into xUnit plugin in some org.jenkins.xunit.lib package? I could adopt DTKit too in case some changes needed to make xUnit works. Out of this discussion: in the organisation pom is defined jacoco, it is possible enable sites like coveralls to see code coverage of a plugin to manage better PRs? I permitted for the Jenkisci organisation do this? <profile> <id>enable-jacoco</id> <build> <pluginManagement> <plugins> <plugin> <groupId>org.eluder.coveralls</groupId> <artifactId>coveralls-maven-plugin</artifactId> <version>4.3.0</version> <configuration> <repoToken>${env.COVERALLS_REPO_TOKEN}</repoToken> </configuration> </plugin> </plugins> </pluginManagement> <plugins> <plugin> <groupId>org.jacoco</groupId> <artifactId>jacoco-maven-plugin</artifactId> <version>0.7.9</version> <executions> <execution> <goals> <goal>prepare-agent</goal> </goals> </execution> <execution> <id>report</id> <phase>test</phase> <goals> <goal>report</goal> </goals> </execution> </executions> </plugin> </plugins> </build> </profile> Il giorno mercoledì 2 maggio 2018 11:07:43 UTC+2, Oleg Nenashev ha scritto: > > Today we were reviewing the XUnit implementation together with Chenyu > Cheng (context - Code Coverage API Plugin GSoC project). We discovered that > the extension points are defined in libdtkit > <https://github.com/jenkinsci/libdtkit> which is a standalone library > within Jenkins organization. So this plugin uses same approaches as > EnvInject Lib and XTrigger Lib :( > > Ideally this library needs to be also adopted and reworked to API plugin > so that it becomes maintainable. DTKit Plugin > <https://github.com/jenkinsci/dtkit-plugin> and TUSAR Notifier > <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fjenkinsci%2Ftusarnotifier-plugin&sa=D&sntz=1&usg=AFQjCNGqRWLFC5yZ8mg0qyzNMbDDY7aZWg> > > plugin are the only usages outside XUnit plugin, but the latter one is > depublished > <https://github.com/jenkins-infra/update-center2/blob/9ffe2b4f0af3a5e96c03279322c3ffb1fb6b19d0/src/main/resources/artifact-ignores.properties#L124>. > > DTKit could be made such API plugin, but I do not exactly understand what > it does in Jenkins now. > > BR, Oleg > > On Monday, April 16, 2018 at 11:12:48 AM UTC+2, Oleg Nenashev wrote: >> >> Thanks for it Nikolas! >> Please feel free to ping me or code-reviewers if you need any help with >> reviews. >> >> Best regards, >> Oleg >> >> On Sunday, April 15, 2018 at 9:32:25 AM UTC+2, Nikolas Falco wrote: >>> >>> Good news, a pull request has been submitted - >>> https://github.com/jenkins-infra/repository-permissions-updater/pull/668 >>> >>> Il giorno mercoledì 11 aprile 2018 23:48:35 UTC+2, Andrew Bayer ha >>> scritto: >>>> >>>> That'd be fine by me. >>>> >>>> A. >>>> >>>> On Mon, Apr 9, 2018 at 6:35 AM, 'Nikolas Falco' via Jenkins Developers >>>> <[email protected]> wrote: >>>> >>>>> I know that the xUnit plugin was already adopted on 15/11/2017 ( >>>>> https://groups.google.com/forum/#!searchin/jenkinsci-dev/xunit%7Csort:date/jenkinsci-dev/RROnSHD36-A/u4DcVHygAQAJ >>>>> ) >>>>> >>>>> Jimilian, one month ago had ask news about movement on the plugin (for >>>>> example pending PRs already approved by Oleg). >>>>> In my society we are using xUnit but recently we had a blocking issue. >>>>> We already open a PR and a JIRA issue (JENKINS-50658) but from what I >>>>> can see there are not commits on the plugin since 2016 and no response to >>>>> any JIRA issue. >>>>> >>>>> Maybe abayer is very busy in develop of other cloudbee plugins so if >>>>> is not a problem I would be added as co-adopter (at least) of the xUnit >>>>> plugin to manage and fix (at least) the actual approved PRs, move plugin >>>>> under pipeline, update parent pom and other minor fixes. >>>>> >>>>> Best Regards >>>>> Falco Nikolas >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Jenkins Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/jenkinsci-dev/72a5095b-cce4-42f0-9192-8733e6da3ba6%40googlegroups.com >>>>> >>>>> <https://groups.google.com/d/msgid/jenkinsci-dev/72a5095b-cce4-42f0-9192-8733e6da3ba6%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/e741f039-48ba-4aa6-b299-629f70322826%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
