Hello Daniel, A few thoughts:
* How does this relate to JENKINS-32485 <https://issues.jenkins-ci.org/browse/JENKINS-32485>? I seem to understand it could well cover it, apart from the required end date? * "Time period (start and end date) during which data collection is enabled on the client (end date is mandatory)" I am not sure I get this one (I am going to have a look at the implem, but I refrained on purpose since I guess the spec ideally ought to not need one to look in the code to get it). Does this mean plugins will add an extension point for the new Telemetry class, and at some point, after the end date, that code will be dead code (that will aggressively be removed from core I suppose)? Do/should we define a max date? If implem says it ends in 2099, I suppose it's well like they didn't put any end date? :) As the spec does cover the link and "reasoning" about how it relates to JEP 308, this proposal looks fine to me as such. Le mer. 12 sept. 2018 à 00:28, Daniel Beck <[email protected]> a écrit : > Hi everyone, > > We're making pretty good progress here. > > The JEP got a few updates (one in progress[1]), Tyler is working hard on > the infra service receiving the submissions[2], and the core PR is in > review, is basically "just" lacking tests right now[3]. > > If you're interested in this proposal, now would be a good time to provide > feedback. > > Thanks! > Daniel > > 1: https://github.com/jenkinsci/jep/pull/196 > 2: https://github.com/rtyler/uplink/ > 3: https://github.com/jenkinsci/jenkins/pull/3604 > > > On 30. Aug 2018, at 12:43, Daniel Beck <[email protected]> wrote: > > > > JEP draft for review at: > > https://github.com/jenkinsci/jep/pull/192 > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/59BB8929-3BA0-4D33-8C5F-ADCB25FF2080%40beckweb.net > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS56zsR9A%2BgsU-aV_UbHjf9S6CEjpCtosmKuoLDPeXBPhg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
