Changing the recommended LTS baseline was discussed in this thread <https://groups.google.com/forum/#!topic/jenkinsci-dev/lmZ_e7eFh2k> in Aug 2019. At that point we did not come to a decision, and the topic was frozen for a while. Note that the Pipeline Library documentation is explicit about it: *"It is also possible to use a buildPlugin.recommendedConfigurations() method to get recommended configurations for testing. Note that the recommended configuration may change over time, and hence your CI may break if the new recommended configuration is not compatible". *So the breaking behavior is expected but indeed undesired. And there is no explicit criteria though I had "latest LTS baseline" as a target when creating this method.
What we could do is to tweak the buildPlugin() logic to ensure that it does not fail the build when newer configuration fails. Instead of that we could send warnings to the pull request via a message or additional Checks status. Best regards, Oleg On Saturday, May 2, 2020 at 12:14:47 PM UTC+2, Ullrich Hafner wrote: > > BTW: this is yet another argument for disabling the enforcer. Or at least > add slf4j to the list of ignores. > > Am 02.05.2020 um 05:34 schrieb Richard Bywater <[email protected] > <javascript:>>: > > Thanks all - I've got the build to work again by removing > recommendedConfigurations and switching to explicitly building the minimum > version of Jenkins that is referenced in the pom.xml for now. I also could > fix the issue with upping the slf4jversion parameter but it seemed wrong to > do this when I don't have any particular reason in the plugin to have that > particular version. I guess I kind of expected the bom to handle that type > of thing for me but I assume that's tracking what libraries were available > for that particular version of Jenkins? > > It would be useful if there was some kind of "minimum" configuration > version defined which was defined by, say, the earliest LTS version which > has greater than x% usage so that you don't have to keep as up-to-date as > you seem to have to have to with recommendedConfigurations. > > Out of interest, is there a set of criteria about why a version is > recommended? By my calculation (and it seems quite high so is possibly > wrong) by moving from a minimum version of 2.164.3 to the recommended > 2.222.3 would mean that about 60% of current users would drop out of > support? > > (Sorry if this message seems confused but it kind of echoes my mind at the > moment :D) > > Richard. > > On Sat, 2 May 2020 at 13:06, Mark Waite <[email protected] <javascript:>> > wrote: > >> I misspoke, it was previously testing with Jenkins 2.164 and is now >> testing with 2.222. Same principles apply. >> >> On Fri, May 1, 2020 at 7:03 PM Mark Waite <[email protected] >> <javascript:>> wrote: >> >>> Yes, that's expected, at least in the sense that changes to the pipeline >>> library are applied to repositories unless the repository specifically >>> loads a precise version of the pipeline library. >>> >>> In this case, the change is a switch from compiling and testing with >>> Jenkins 1.190.x to instead compile and test with Jenkins 2.222.x. That's >>> part of the ci.jenkins.io buildPlugin() call for recommended >>> configurations. >>> >>> Usually that hints that it may be time to consider updating the minimum >>> Jenkins version supported by your plugin. >>> >>> As an example, I did some analysis of the Jenkins installed versions of >>> the git plugin and decided that it is now time to update the minimum >>> Jenkins version required for the git plugin. The current minimum version >>> is Jenkins 2.138 (yes, that is a very, very old Jenkins version). The next >>> git plugin release will require at least Jenkins 2.204. >>> >>> Mark Waite >>> >>> On Fri, May 1, 2020 at 6:52 PM Richard Bywater <[email protected] >>> <javascript:>> wrote: >>> >>>> Just wondering if its expected that updates to Jenkins-Infra pipeline >>>> library might cause issues on builds that have no changes to pom.xml etc.? >>>> >>>> Looks like there was a pipeline library change made between >>>> https://ci.jenkins.io/job/Plugins/job/htmlpublisher-plugin/job/PR-56/1/ >>>> and >>>> https://ci.jenkins.io/job/Plugins/job/htmlpublisher-plugin/job/PR-56/2/ >>>> which has broken the build due to library version issues such as : >>>> >>>> *12:28:10* Failed while enforcing RequireUpperBoundDeps. The error(s) are >>>> [*12:28:10* Require upper bound dependencies error for >>>> org.slf4j:jcl-over-slf4j:1.7.25 paths to dependency are:*12:28:10* >>>> +-org.jenkins-ci.plugins:htmlpublisher:1.23-SNAPSHOT*12:28:10* >>>> +-org.slf4j:jcl-over-slf4j:1.7.25*12:28:10* and*12:28:10* >>>> +-org.jenkins-ci.plugins:htmlpublisher:1.23-SNAPSHOT*12:28:10* >>>> +-org.jenkins-ci.main:jenkins-core:2.222.3*12:28:10* >>>> +-org.slf4j:jcl-over-slf4j:1.7.25 (managed) <-- >>>> org.slf4j:jcl-over-slf4j:1.7.26 >>>> >>>> Not sure if there's an issue with my pom.xml or similar that needs fixing >>>> but thought it strange it would >>>> suddenly break. >>>> >>>> Any help gratefully received :) >>>> >>>> Richard. >>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Jenkins Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected] <javascript:>. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAAy0hwftkMA7_BTaW2tZj1-02WeyyVtWrWtSU6nKWMFP7jk7YA%40mail.gmail.com >>>> >>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAAy0hwftkMA7_BTaW2tZj1-02WeyyVtWrWtSU6nKWMFP7jk7YA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFAA62bnAue%3DiegAb04Fk0rvQDHqsc0k5O8BCuQPj6bsw%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFAA62bnAue%3DiegAb04Fk0rvQDHqsc0k5O8BCuQPj6bsw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAAy0hwdMy1ag%3DmF-346B56EUGTPSu2D9nGCkw3gE9b-epCKRPw%40mail.gmail.com > > <https://groups.google.com/d/msgid/jenkinsci-dev/CAAy0hwdMy1ag%3DmF-346B56EUGTPSu2D9nGCkw3gE9b-epCKRPw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/fab1b313-42aa-4eef-a990-f5fbbee061aa%40googlegroups.com.
