On Tue, 5 May 2020 at 01:01, Jesse Glick <[email protected]> wrote:
> > I've got the build to work again by removing recommendedConfigurations > and switching to explicitly building the minimum version of Jenkins that is > referenced in the pom.xml > > This makes no sense. If you _only_ want to build the version > referenced in `pom.xml`, just > > buildPlugin() > > The point of `configurations` is to build against _newer_ versions as well. > Thanks - I didn't realise that. After reading the README https://github.com/jenkins-infra/pipeline-library I wasn't clear on what the default behaviour was if you didn't specify any of the optional arguments. I'm also confused by the statement "Gradle support in buildPlugin() is deprecated and will be eventually removed. Please use buildPluginWithGradle()". Is that actually accurate? Should we be using Gradle builds by default now? > > > I also could fix the issue with upping the slf4jversion parameter but it > seemed wrong to do this when I don't have any particular reason in the > plugin to have that particular version. I guess I kind of expected the bom > to handle that type of thing for me > > It does. You should switch to a 4.x version of the parent POM. > Ah ok. When I was searching I somehow managed to miss https://www.jenkins.io/doc/developer/plugin-development/dependency-management/ and its related links so I'll follow through those pages. If someone who is familiar with the BOMs & POMs could take a quick review of https://github.com/jenkinsci/htmlpublisher-plugin/pull/57 just to make sure I'm not digging myself deeper into the ditch that would be most appreciated :) Thanks Richard. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAAy0hwfZO_8%2BMmusa0T90AtpEvyWSSXDcZnkvv_WN6dnToXANw%40mail.gmail.com.
