We have reverted the recommendedConfigurations() patch for now. Back to the drawing board, we still need to somehow ensure that recommended configurations can evolve without breaking instances.
On Tuesday, May 5, 2020 at 3:01:35 AM UTC+2, Richard Bywater wrote: > > Thanks. I totally somehow missed the "Gradle support in" part of that both > when I read it the couple of times and when I pasted... Time for a break I > think! > > Richard. > > On Tue, 5 May 2020 at 12:59, Slide <[email protected] <javascript:>> > wrote: > >> >> >> On Mon, May 4, 2020 at 5:53 PM Richard Bywater <[email protected] >> <javascript:>> wrote: >> >>> On Tue, 5 May 2020 at 01:01, Jesse Glick <[email protected] >>> <javascript:>> wrote: >>> >>>> > I've got the build to work again by removing >>>> recommendedConfigurations and switching to explicitly building the minimum >>>> version of Jenkins that is referenced in the pom.xml >>>> >>>> This makes no sense. If you _only_ want to build the version >>>> referenced in `pom.xml`, just >>>> >>>> buildPlugin() >>>> >>>> The point of `configurations` is to build against _newer_ versions as >>>> well. >>>> >>> >>> Thanks - I didn't realise that. After reading the README >>> https://github.com/jenkins-infra/pipeline-library I wasn't clear on >>> what the default behaviour was if you didn't specify any of the optional >>> arguments. I'm also confused by the statement "Gradle support in >>> buildPlugin() is deprecated and will be eventually removed. Please use >>> buildPluginWithGradle()". Is that actually accurate? Should we be using >>> Gradle builds by default now? >>> >>> >> >> This just means that if you use Gradle to build your plugin, you should >> not be using buildPlugin() anymore, you should use buildPluginWithGradle() >> instead. Maven builds are still the normal and most supported method for >> building Jenkins plugins. >> >> -- >> Website: http://earl-of-code.com >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVd%2BvoxjEASVCO30C9iobk2aDGp2fwZNWjvSj4P1X-uLyQ%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVd%2BvoxjEASVCO30C9iobk2aDGp2fwZNWjvSj4P1X-uLyQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/fa6c7004-8e6a-4158-9bc1-eedea23cdb2f%40googlegroups.com.
