On Thu, Jun 10, 2021 at 10:03 AM jn...@cloudbees.com <jn...@cloudbees.com> wrote: > > 1 -> Which is fine until the library evolves in a binary incompatible way.. > and the ASM library is KNOWN to do this. > 2-> has many pitfalls and this only works if no one else depends on your > plugin otherwise they also get those classes (ref the jacoco guice inject > mess)
Agreed. That's why I said the status quo is "not ideal". But by and large it works well enough to keep the ecosystem stable. > 3 -> requires a larger restructuring of plugins to enable that and I look > forward to the PRs. I am not planning on opening any such PRs, and I am not sure why you would think that I am. Please remember that I am a volunteer and am just trying to help where I can. An encouraging and constructive tone would be appreciated. > I do not believe this to be correct, the core class will resolve ASM using > the core classes' classloader not the plugins classloader even when invoked > from the plugin. I trust you, but I am having a hard time understanding the behavior observed empirically here: https://github.com/jenkinsci/subversion-plugin/pull/254#issuecomment-858288074 Based on your statement, I would expect the core class (Stapler) to "resolve ASM using the core classes' classloader not the plugins classloader even when invoked from the plugin". This implies that whether Subversion bundles ASM or not, Stapler should use the ASM provided by core. But yet running that test against 2.297 passes when Subversion doesn't bundle ASM and fails when Subversion does bundle ASM, implying that the ASM available to Stapler somehow differs based on the plugin, contradicting the earlier implication. I think we have not yet gotten to the bottom of this. Perhaps someone like Jesse might be able to shed some light about what is happening here. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpbPTnmZuaAxrQEbm1msDQo7wde7LYNz4A3gbYNfXgsZg%40mail.gmail.com.
