Heyo, that is an interesting proposal. Currently, there are quite a lot of stale pull requests, whether labeled with a stale-like label or not, which's state is unclear how to proceed with them. I think working with labels is easier, instead of converting the PRs into drafts, because a stale draft PR hardly differs from a draft that is work in progress. A label can show that state well without the need to read over the PR again.
> Also, there is no mention of those labels, what they means and how we use it on our contribution guide [1]. Should we add a mention of those label on it? There's an overview of all labels available on https://github.com/jenkinsci/jenkins/labels. We could fill in missing descriptions and overhaul existing ones, if needed. The contribution guide could link to the former URL where you can browse PRs with specific labels right away. ~ Alex On Tuesday, 22 March 2022 at 17:27:34 UTC+1 [email protected] wrote: > This seems reasonable to me. After some period of time (months? years?) > the PR is unlikely to be merged, so why keep it open if it's truly stale? > > > On Tue, Mar 22, 2022 at 9:07 AM Adrien Lecharpentier < > [email protected]> wrote: > >> Hello everyone, >> >> I've spent some time lately on looking at the pull-requests on >> jenkinsci/jenkins repository. For some old, inactive pull-requests I've >> pinged the authors and for some, added the proposed-for-close label. >> >> However, the label description nor any prior discussion on the >> mailing-list are mentioning our policy about this (proposed-for-close) >> label. And I'd like to offer one: I'd like, as for the ready-for-merge >> label, to introduce a period of time, after which with no response from the >> author, we close the pull-request. I was thinking about 72 or 96hr. >> >> This might seem a bit harsh, but my idea is to try to keep the >> pull-requests list healthy. And when we have no consensus on the PR or no >> response from the authors, it's healthier to close the pull-request. The >> work done is not lost, the PR can be reopen later when the author is more >> available to attend to it. >> >> Also, in case the authors respond, we can simply put the label stalled >> (for others to take over the PR). We could also put the PR back into draft, >> but all members have enough permission to do that on others pull-requests, >> but we could use the work-in-progress. Of course, after another period of >> time, with no more activities, we should close the PR anyway. >> >> Also, there is no mention of those labels, what they means and how we use >> it on our contribution guide [1]. Should we add a mention of those label on >> it? >> >> -- Adrien >> >> [1]: https://github.com/jenkinsci/jenkins/blob/master/CONTRIBUTING.md >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Jenkins Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvwTnxuwe1WZzs3eSJBgq783fMm8hkQ_-%3DFHS1u0%2B7GUAw%40mail.gmail.com >> >> <https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvwTnxuwe1WZzs3eSJBgq783fMm8hkQ_-%3DFHS1u0%2B7GUAw%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/9dbeedc8-63a8-4c8e-b31f-252e8840d394n%40googlegroups.com.
