On Wed, 23 Mar 2022 at 02:07, Adrien Lecharpentier < [email protected]> wrote:
> Hello everyone, > > I've spent some time lately on looking at the pull-requests on > jenkinsci/jenkins repository. For some old, inactive pull-requests I've > pinged the authors and for some, added the proposed-for-close label. > > However, the label description nor any prior discussion on the > mailing-list are mentioning our policy about this (proposed-for-close) > label. And I'd like to offer one: I'd like, as for the ready-for-merge > label, to introduce a period of time, after which with no response from the > author, we close the pull-request. I was thinking about 72 or 96hr. > Definitely sounds good to clean up some stale/dead PRs but I find 96h a bit too short. (people can be off for few days/weeks and 1 or 2 weeks for 2 yo old PR will not hurt more) I have implemented something similar in some plugins using stale action see configuration here https://github.com/jenkinsci/maven-plugin/blob/master/.github/workflows/stale.yml (tool here: https://github.com/actions/stale) with this configuration PRs 365 days old are marked stale then after 30 days they are closed. > > This might seem a bit harsh, but my idea is to try to keep the > pull-requests list healthy. And when we have no consensus on the PR or no > response from the authors, it's healthier to close the pull-request. The > work done is not lost, the PR can be reopen later when the author is more > available to attend to it. > > Also, in case the authors respond, we can simply put the label stalled > (for others to take over the PR). We could also put the PR back into draft, > but all members have enough permission to do that on others pull-requests, > but we could use the work-in-progress. Of course, after another period of > time, with no more activities, we should close the PR anyway. > > Also, there is no mention of those labels, what they means and how we use > it on our contribution guide [1]. Should we add a mention of those label on > it? > > -- Adrien > > [1]: https://github.com/jenkinsci/jenkins/blob/master/CONTRIBUTING.md > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvwTnxuwe1WZzs3eSJBgq783fMm8hkQ_-%3DFHS1u0%2B7GUAw%40mail.gmail.com > <https://groups.google.com/d/msgid/jenkinsci-dev/CAKwJSvwTnxuwe1WZzs3eSJBgq783fMm8hkQ_-%3DFHS1u0%2B7GUAw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPoyBqTayEyLwyfXcaaE4bsSLOTj6YRPw5M%2BstBeiekq3F7TUA%40mail.gmail.com.
