[GitHub] [kafka] ijuma commented on a diff in pull request #12441: KAFKA-14108: Ensure both JUnit 4 and JUnit 5 tests run

[GitBox]

ijuma commented on code in PR #12441:
URL: https://github.com/apache/kafka/pull/12441#discussion_r929996127


##########
build.gradle:
##########
@@ -466,6 +466,10 @@ subprojects {
     if (shouldUseJUnit5) {
       useJUnitPlatform {
         includeTags "integration"
+        // KAFKA-14109
+        // Both engines are needed to run JUnit 4 tests alongside JUnit 5 
tests.
+        // junit-vintage (JUnit 4) can be removed once the JUnit 4 migration 
is complete.
+        includeEngines "junit-vintage", "junit-jupiter"

Review Comment:
   We don't want to do this for all modules since most of them have already 
been converted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org