cadonna commented on code in PR #12441: URL: https://github.com/apache/kafka/pull/12441#discussion_r932242390
########## gradle/dependencies.gradle: ########## @@ -159,6 +159,10 @@ libs += [ jmhGeneratorAnnProcess: "org.openjdk.jmh:jmh-generator-annprocess:$versions.jmh", joptSimple: "net.sf.jopt-simple:jopt-simple:$versions.jopt", jose4j: "org.bitbucket.b_c:jose4j:$versions.jose4j", + // KAFKA-14109 + // The below dependency is needed for compiling JUnit 4 tests. + // It can be safely removed once all of streams has moved to JUnit 5. + junit4: "junit:junit:$versions.junit4", Review Comment: I did some tests and discovered that `junitVintageEngine` pulls in JUnit 4. That means if we move `junitVintageEngine` back to the `testImplementation` dependencies compilation of JUnit4 tests works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
