divijvaidya commented on code in PR #12441:
URL: https://github.com/apache/kafka/pull/12441#discussion_r930013162
##########
build.gradle:
##########
@@ -466,6 +466,10 @@ subprojects {
if (shouldUseJUnit5) {
useJUnitPlatform {
includeTags "integration"
+ // KAFKA-14109
+ // Both engines are needed to run JUnit 4 tests alongside JUnit 5
tests.
+ // junit-vintage (JUnit 4) can be removed once the JUnit 4 migration
is complete.
+ includeEngines "junit-vintage", "junit-jupiter"
Review Comment:
Is there a disadvantage/side-effect if we do it for all the modules?
From what I understand (please correct me if I am wrong), loading the
vintage engine for JUnit5 tests won't have any side effects since they would be
run with jupiter engine anyways. Vintage engine only runs Junit4 tests in a
Junit5 platform. It does not impact already converted Junit5 tests running on
Junit5 platform.
I am advocating for this because it keeps the changes minimal and simplified
here. Given that it is a temporary transient stage (we already have PRs out for
most of the test conversion to JUnit5), I would preferr minimal changes so that
reverting them is easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
