cmccabe commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r949687749
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1142,15 +1142,19 @@ private void renounce() {
purgatory.failAll(newNotControllerException());
if (snapshotRegistry.hasSnapshot(lastCommittedOffset)) {
- newBytesSinceLastSnapshot = 0;
snapshotRegistry.revertToSnapshot(lastCommittedOffset);
authorizer.ifPresent(a ->
a.loadSnapshot(aclControlManager.idToAcl()));
} else {
- resetState();
+ log.warn("Unable to find last committed offset {} in snapshot
registry; resetting " +
Review Comment:
it is expected, unfortunately. we have some ideas for fixing this, but it's
outside the scope of this PR.
I guess you're hinting that this should be an INFO? :) I'll make it an INFO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
