cmccabe commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r949693455
##########
metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java:
##########
@@ -222,52 +227,130 @@ public void testFeatureControlIterator() throws
Exception {
manager.iterator(Long.MAX_VALUE));
}
+ private static final FeatureControlManager.Builder TEST_MANAGER_BUILDER1 =
+ new FeatureControlManager.Builder().
+ setQuorumFeatures(features(MetadataVersion.FEATURE_NAME,
+ MetadataVersion.IBP_3_3_IV0.featureLevel(),
MetadataVersion.IBP_3_3_IV3.featureLevel())).
+ setMetadataVersion(MetadataVersion.IBP_3_3_IV2);
+
@Test
public void testApplyMetadataVersionChangeRecord() {
- QuorumFeatures features = features(MetadataVersion.FEATURE_NAME,
- MetadataVersion.IBP_3_0_IV1.featureLevel(),
MetadataVersion.IBP_3_3_IV0.featureLevel());
- FeatureControlManager manager = new FeatureControlManager.Builder().
- setQuorumFeatures(features).build();
+ FeatureControlManager manager = TEST_MANAGER_BUILDER1.build();
manager.replay(new FeatureLevelRecord().
setName(MetadataVersion.FEATURE_NAME).
- setFeatureLevel(MetadataVersion.IBP_3_0_IV1.featureLevel()));
- assertEquals(MetadataVersion.IBP_3_0_IV1, manager.metadataVersion());
+ setFeatureLevel(MetadataVersion.IBP_3_3_IV3.featureLevel()));
+ assertEquals(MetadataVersion.IBP_3_3_IV3, manager.metadataVersion());
}
@Test
- public void testDowngradeMetadataVersion() {
- QuorumFeatures features = features(MetadataVersion.FEATURE_NAME,
- MetadataVersion.IBP_3_2_IV0.featureLevel(),
MetadataVersion.IBP_3_3_IV0.featureLevel());
- FeatureControlManager manager = new FeatureControlManager.Builder().
- setQuorumFeatures(features).
- setMetadataVersion(MetadataVersion.IBP_3_3_IV0).
- build();
- assertEquals(manager.metadataVersion(), MetadataVersion.IBP_3_3_IV0);
+ public void
testCannotDowngradeToVersionBeforeMinimumSupportedKraftVersion() {
+ FeatureControlManager manager = TEST_MANAGER_BUILDER1.build();
+ assertEquals(ControllerResult.of(Collections.emptyList(),
+ singletonMap(MetadataVersion.FEATURE_NAME, new
ApiError(Errors.INVALID_UPDATE_VERSION,
+ "Invalid update version 3 for feature metadata.version. Local
controller 0 only " +
+ "supports versions 4-7"))),
+ manager.updateFeatures(
+ singletonMap(MetadataVersion.FEATURE_NAME,
MetadataVersion.IBP_3_2_IV0.featureLevel()),
+ singletonMap(MetadataVersion.FEATURE_NAME,
FeatureUpdate.UpgradeType.UNSAFE_DOWNGRADE),
+ emptyMap(),
+ true));
+ }
+
+ @Test
+ public void testCannotDowngradeToHigherVersion() {
+ FeatureControlManager manager = TEST_MANAGER_BUILDER1.build();
+ assertEquals(ControllerResult.of(Collections.emptyList(),
+ singletonMap(MetadataVersion.FEATURE_NAME, new
ApiError(Errors.INVALID_UPDATE_VERSION,
+ "Invalid update version 7 for feature metadata.version. Can't
downgrade to a " +
+ "newer version."))),
+ manager.updateFeatures(
+ singletonMap(MetadataVersion.FEATURE_NAME,
MetadataVersion.IBP_3_3_IV3.featureLevel()),
+ singletonMap(MetadataVersion.FEATURE_NAME,
FeatureUpdate.UpgradeType.SAFE_DOWNGRADE),
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
