cmccabe commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r949694015
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -952,6 +966,7 @@ public void testEarlyControllerResults() throws Throwable {
}
}
+ @Disabled // TODO: need to fix leader election in LocalLog.
Review Comment:
It's not flaky, but this PR did break it.
This PR exposes a bug in `LocalLogManager`, which is that it doesn't really
do leader election properly. I started to fix that bug, but then I ended up
rewriting big parts of LocalLogManager, which doesn't seem appropriate for 3.3,
so I shelved it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]