divijvaidya commented on PR #12684: URL: https://github.com/apache/kafka/pull/12684#issuecomment-1259199080
1. (Calling this out for completeness sake) `Instant.ofEpochMilli` is slower than existing solution but it is worth making this change for the sake of readability of logs. It will improve operator's life while debugging logs. 2. Another aspect that impacts readability is that the consistency of time representation in the logs. For example, the pattern used to format the timestamp of the log at the beginning of the line is `2022-09-24 18:28:24,248` (DEFAULT pattern for SimpleDateFormatter) but the format of time for nextProbingRebalance after this change is ISO_8601 i.e. `2022-09-24T13:08:24.247Z`. The `nextProbingRebalance` will always be in UTC but the time at the beginning of the log line will be as per system's default timezone. This will cause confusion for the operator. Hence, I would suggest to follow the same time zone (and preferably the same date format) as the log4j formatter to represent human readable time in middle of the logs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
