divijvaidya commented on code in PR #12684:
URL: https://github.com/apache/kafka/pull/12684#discussion_r997381071
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##########
@@ -1447,6 +1450,11 @@ private int updateMinSupportedVersion(final int
supportedVersion, final int minS
}
}
+ private String formatInstantTime(final long instant) {
Review Comment:
As you suggested, this function would be a better fit for a Util class
because it's being used twice across two different classes.
Perhaps rename it to `ToLogDateTimeFormat()` and add it to a new class
`commons.utils.LoggingUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
