cmccabe commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1011283871
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -269,6 +270,26 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
addBrokerReconfigurable(kafkaServer.logManager.producerStateManagerConfig)
}
+ /**
+ * Add reconfigurables to be notified when a dynamic controller config is
updated.
+ */
+ def addReconfigurables(controller: ControllerServer): Unit = {
+ controller.authorizer match {
+ case Some(authz: Reconfigurable) => addReconfigurable(authz)
+ case _ =>
+ }
+ if (!kafkaConfig.processRoles.contains(BrokerRole)) {
+ // In combined mode, these elements are shared between broker and
controller, and therefore
+ // don't need to be updated here (since the broker will do it.)
+ addReconfigurable(controller.kafkaYammerMetrics)
+ addReconfigurable(new DynamicMetricsReporters(
+ kafkaConfig.brokerId, controller.config, controller.metrics,
controller.clusterId))
+ }
+ // TODO: add dynamic thread pool resizing here
Review Comment:
Good point. I created KAFKA-14349, KAFKA-14350, and KAFKA-14351. I will also
add comments about them here.
KAFKA-14351 is for controller mutation quotas as a whole (I thought we had
that already but I didn't see it, so I created it and linked the appropriate
places.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
