cmccabe commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1011288444
##########
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##########
@@ -191,21 +191,36 @@ public KafkaClusterTestKit build() throws Exception {
KafkaRaftManager<ApiMessageAndVersion> raftManager = new
KafkaRaftManager<>(
metaProperties, config, new MetadataRecordSerde(),
metadataPartition, KafkaRaftServer.MetadataTopicId(),
Time.SYSTEM, new Metrics(),
Option.apply(threadNamePrefix), connectFutureManager.future);
- ControllerServer controller = new ControllerServer(
- nodes.controllerProperties(node.id()),
- config,
- raftManager,
- Time.SYSTEM,
- new Metrics(),
- new MockControllerMetrics(),
- Option.apply(threadNamePrefix),
- connectFutureManager.future,
- KafkaRaftServer.configSchema(),
- raftManager.apiVersions(),
- bootstrapMetadata,
- metadataFaultHandler,
- fatalFaultHandler
- );
+ MetadataLoader metadataLoader = null;
+ ControllerServer controller = null;
+ try {
+ metadataLoader = new MetadataLoader.Builder().
+ setNodeId(node.id()).
+ setTime(Time.SYSTEM).
+ setThreadNamePrefix(threadNamePrefix).
+ setFaultHandler(fatalFaultHandler).
+ build();
+ controller = new ControllerServer(
+ nodes.controllerProperties(node.id()),
+ config,
+ raftManager,
+ Time.SYSTEM,
+ new Metrics(),
+ new MockControllerMetrics(),
+ Option.apply(threadNamePrefix),
+ connectFutureManager.future,
+ KafkaRaftServer.configSchema(),
+ raftManager.apiVersions(),
+ bootstrapMetadata,
+ metadataFaultHandler,
+ fatalFaultHandler,
+ metadataLoader);
+ } catch (Throwable e) {
+ log.error("Error creating controller {}", node.id(),
e);
+ metadataLoader.close();
+ controller.shutdown();
Review Comment:
good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
