cmccabe commented on code in PR #12776:
URL: https://github.com/apache/kafka/pull/12776#discussion_r1011285453
##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -258,6 +264,14 @@ class ControllerServer(
shutdown()
throw e
}
+ config.dynamicConfig.addReconfigurables(this)
+ dynamicConfigHandlers = immutable.Map[String, ConfigHandler](
+ ConfigType.Broker -> new BrokerConfigHandler(config, quotaManagers))
+ controllerMetadataPublisher = new ControllerMetadataPublisher(
+ config,
+ dynamicConfigHandlers,
+ fatalFaultHandler)
+ metadataLoader.installPublishers(List().asJava)
Review Comment:
Yes, good catch. I am adding more tests for this (maybe not tonight but
tomorrow morning for sure)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
