vamossagar12 commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1061433053
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -780,6 +774,14 @@ protected void stopServices() {
}
}
+ // Timeout for herderExecutor to gracefully terminate is set to a value to
accommodate
+ // reading to the end of the config topic + successfully attempting to
stop all connectors and tasks and a buffer of 10s
+ private long getHerderExecutorTimeoutMs() {
Review Comment:
I created a separate method for this as it appeared slightly cleaner and in
the future if we want to add more parameters when calculating the
herderExecutor, the change would be made at one place. Don't have a strong
preference on this and if you feel I should remove it, can do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
