cmccabe commented on code in PR #12965:
URL: https://github.com/apache/kafka/pull/12965#discussion_r1043910049
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -81,6 +84,19 @@ object KafkaServer {
clientConfig
}
+ def zkClient(name: String, time: Time, config: KafkaConfig, zkClientConfig:
ZKClientConfig): KafkaZkClient = {
Review Comment:
Hmm. Maybe I'm missing something, but I don't see any relationship with
`KafkaServer`. Why put this in `KafkaServer.scala`? Can this be a `static`
function in `KafkaZkClient.scala`? (aka "function on `object KafkaZkClient`")?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
