cmccabe commented on code in PR #12965:
URL: https://github.com/apache/kafka/pull/12965#discussion_r1043911573
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -690,6 +772,14 @@ class KafkaServer(
_brokerState = BrokerState.PENDING_CONTROLLED_SHUTDOWN
+ if (config.migrationEnabled && lifecycleManager != null) {
+ // TODO KAFKA-14447 Only use KRaft controlled shutdown (when in
migration mode)
Review Comment:
so the TODO here is that we need to check if the controller is a kraft one?
fair enough.
I keep thinking that info should be in the metadata cache ... I guess we can
do that in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
