mumrah commented on code in PR #12965:
URL: https://github.com/apache/kafka/pull/12965#discussion_r1044606857
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -81,6 +84,19 @@ object KafkaServer {
clientConfig
}
+ def zkClient(name: String, time: Time, config: KafkaConfig, zkClientConfig:
ZKClientConfig): KafkaZkClient = {
+ val secureAclsEnabled = config.zkEnableSecureAcls
+ val isZkSecurityEnabled = JaasUtils.isZkSaslEnabled ||
KafkaConfig.zkTlsClientAuthEnabled(zkClientConfig)
+
+ if (secureAclsEnabled && !isZkSecurityEnabled)
+ throw new
java.lang.SecurityException(s"${KafkaConfig.ZkEnableSecureAclsProp} is true,
but ZooKeeper client TLS configuration identifying at least
$KafkaConfig.ZkSslClientEnableProp, $KafkaConfig.ZkClientCnxnSocketProp, and
$KafkaConfig.ZkSslKeyStoreLocationProp was not present and the " +
Review Comment:
Thanks! This was just a copy/paste refactor. I wonder how long this has been
broken 😅
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -81,6 +84,19 @@ object KafkaServer {
clientConfig
}
+ def zkClient(name: String, time: Time, config: KafkaConfig, zkClientConfig:
ZKClientConfig): KafkaZkClient = {
Review Comment:
This was just relocated from elsewhere in KafkaServer. I do agree it's kind
of out of place. I'll move it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
