cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062627093
##########
clients/src/main/resources/common/message/BrokerRegistrationRequest.json:
##########
@@ -51,7 +51,7 @@
},
{ "name": "Rack", "type": "string", "versions": "0+", "nullableVersions":
"0+",
"about": "The rack which this broker is in." },
- { "name": "IsMigratingZkBroker", "type": "bool", "versions": "1+",
"default": "false",
- "about": "Set by a ZK broker if the required configurations for ZK
migration are present." }
+ { "name": "MigratingZkBrokerEpoch", "type": "int64", "versions": "1+",
"default": "-1",
Review Comment:
can you add a comment to the top of `BrokerRegistrationRequest.json` stating
that version 1 adds `MigratingZkBrokerEpoch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
