cmccabe commented on code in PR #12998:
URL: https://github.com/apache/kafka/pull/12998#discussion_r1062640868
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -348,7 +345,7 @@ class KafkaServer(
time = time,
metrics = metrics,
threadNamePrefix = threadNamePrefix,
- brokerEpochSupplier = () => kafkaController.brokerEpoch
+ brokerEpochSupplier = () => brokerEpochManager.get()
Review Comment:
Don't we need to handle the case where `brokerEpochManager` is null here?
You would return -1 in that case.
And probably you also need to make `brokerEpochManager` volatile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
