Hangleton commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1116196039
##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java:
##########
@@ -78,11 +111,18 @@ public OffsetCommitRequestData data() {
return data;
}
- public Map<TopicPartition, Long> offsets() {
+ public Map<TopicPartition, Long> offsets(TopicResolver topicResolver) {
Review Comment:
Sure, I used the auto-generated class in the unit test for the
`OffsetCommitRequest`. I moved this method to the unit test class as it is used
from other unit tests in for the consumer coordinator, from where using the
full-fledged request object would be less convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
